Add a script to produce combined fuzzing coverage profiles. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morehouse
reviewed
Oct 22, 2024
cov_profiles.sh
Outdated
|
|
||
| # Collect coverage profiles. | ||
| for p in ${packages[@]}; do | ||
| cd $PWD/$p/testdata/fuzz |
There was a problem hiding this comment.
It seems BASE_DIR and PWD are being used interchangeably, but it is possible the user runs cov_profiles.sh from a directory other than lnd-fuzz.
We should only use BASE_DIR.
There was a problem hiding this comment.
that is true in the above case but not in for f in $(ls $PWD); do
Crypt-iQ
force-pushed
the
cov_profiles_10_07_2024
branch
from
82d98b2 to
6b373e3
Compare
morehouse
reviewed
Oct 30, 2024
morehouse
reviewed
Oct 30, 2024
gijswijs
reviewed
Nov 5, 2024
| for p in ${packages[@]}; do | ||
| cd "${BASE_DIR}/${p}/testdata/fuzz" | ||
|
|
||
| for f in $(ls $PWD); do |
There was a problem hiding this comment.
You can use for with a glob pattern. ./* is safer than * but both work in this case.
Suggested change
| for f in $(ls $PWD); do | |
| for f in ./*; do |
There was a problem hiding this comment.
For some reason this did not work for me
|
@Crypt-iQ, remember to re-request review from reviewers when ready |
Crypt-iQ
force-pushed
the
cov_profiles_10_07_2024
branch
from
6b373e3 to
9054ca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much a copy of
corpus_merge.sh. After running the script, go to yourlnddirectory then rungo tool cover -html ../lnd-fuzz/coverage/profileto see coverage in HTML.Addresses part of #10