gbn: Sender side only packeting resend bug fix #364
ViktorTigerstrommain.yml
on: pull_request
build package and wasm
6m 8s
lint code
1m 49s
run itests
6m 11s
Matrix: run unit tests
Annotations
10 errors and 5 warnings
|
lint code:
gbn/gbn_conn.go#L402
return statements should not be cuddled if block has more than two lines (wsl)
|
|
lint code:
gbn/gbn_conn.go#L442
only cuddled expressions if assigning variable or using from line above (wsl)
|
|
lint code:
gbn/queue.go#L135
assignments should only be cuddled with other assignments (wsl)
|
|
lint code:
gbn/queue.go#L137
return statements should not be cuddled if block has more than two lines (wsl)
|
|
lint code:
gbn/gbn_conn.go#L394
calculated cyclomatic complexity for function resendQueue is 11, max is 10 (cyclop)
|
|
lint code:
gbn/gbn_conn.go#L441
mnd: Magic number: 7, in <argument> detected (gomnd)
|
|
lint code:
gbn/gbn_conn.go#L803
mnd: Magic number: 2, in <argument> detected (gomnd)
|
|
lint code:
gbn/gbn_conn.go#L451
break with no blank line before (nlreturn)
|
|
lint code:
gbn/gbn_conn.go#L454
break with no blank line before (nlreturn)
|
|
lint code:
gbn/queue.go#L90
return with no blank line before (nlreturn)
|
|
run unit tests (unit)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
run unit tests (unit-race)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint code
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build package and wasm
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
run itests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|