Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenger: paginage ListInvoices to avoid resource exhaustion #160

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

bhandras
Copy link
Member

No description provided.

@bhandras bhandras force-pushed the paginate-listinvoices branch from 03018ad to c3bc03f Compare January 13, 2025 13:36
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! One question.

challenger/lnd.go Outdated Show resolved Hide resolved
@bhandras bhandras force-pushed the paginate-listinvoices branch from c3bc03f to ed3b9a7 Compare January 13, 2025 13:43
@bhandras bhandras requested a review from guggero January 13, 2025 13:44
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM 🎉

challenger/lnd.go Show resolved Hide resolved
@bhandras bhandras force-pushed the paginate-listinvoices branch from ed3b9a7 to 6f11a96 Compare January 13, 2025 13:52
@bhandras bhandras force-pushed the paginate-listinvoices branch from 6f11a96 to 8ec6c28 Compare January 13, 2025 14:58
@guggero guggero merged commit 3d3e042 into lightninglabs:master Jan 13, 2025
5 checks passed
@bhandras bhandras deleted the paginate-listinvoices branch January 13, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants