Stop sending channel_update in onion failures
#3345
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3345 +/- ##
==========================================
- Coverage 89.67% 89.55% -0.12%
==========================================
Files 126 127 +1
Lines 103165 103469 +304
Branches 103165 103469 +304
==========================================
+ Hits 92510 92660 +150
- Misses 7935 8104 +169
+ Partials 2720 2705 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| let failure_code = 0x1000|7; | ||
| let data = self.get_htlc_inbound_temp_fail_data(failure_code); |
There was a problem hiding this comment.
IMHO there was no reason to change the function return type, is it?
There was a problem hiding this comment.
In case this function failed to fetch the channel_update, it previously indicated this to the caller by returning an 0x4000 error, and the caller would reassign the 0x1000 code with the 0x4000 code.
In case the channel_update fetch was successful, the returned error code was the same as the one passed in.
This function no longer has this potential fetch failure, so it will never reassign the error code value to a different value. So we don't need to return an error code value any longer.
There was a problem hiding this comment.
Yeah I noted it, and make sense of your explaination. Probably just bias because the previous function was more "elegant" from the code point of view. Thanks for explaination
| let failure_code = 0x1000|7; | ||
| let data = self.get_htlc_inbound_temp_fail_data(failure_code); |
Sorry I should have understood better, thank you for the review ! |
tankyleo
force-pushed
the
onion-channel-updates
branch
from
1d29256
to
66f1825
Compare
| // See https://github.com/lightning/bolts/blob/341ec84/04-onion-routing.md?plain=1#L1008 | ||
| 0u16.write(&mut enc).expect("Writes cannot fail"); | ||
| } | ||
| (0u16).write(&mut enc).expect("Writes cannot fail"); |
There was a problem hiding this comment.
I know it seems kind of obvious for no channel update, but could we perhaps link to https://github.com/lightning/bolts/blob/247e83d528a2a380e533e89f31918d7b0ce6a0c1/04-onion-routing.md?plain=1#L1414-L1415 in a comment?
Sorry for only seeing this now!
There was a problem hiding this comment.
No problem you are right, I think it's worth adding this reference.
There was a problem hiding this comment.
Please see below, I added the link in the two places where it is relevant.
I only included the first 7 characters of the commit hash, partly to keep it consistent with the link further above in the location you pointed out.
tankyleo
force-pushed
the
onion-channel-updates
branch
from
66f1825
to
9e30f25
Compare
| let mut fail_conditions = PaymentFailedConditions::new() | ||
| .blamed_scid(phantom_scid) | ||
| .expected_htlc_error_data(0x2000 | 2, &[]); | ||
| .expected_htlc_error_data(0x1000 | 13, &err_data); |
Per lightning/bolts#1173.
Fixes #3277