Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fixture to verify snapshot update recency. #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create fixture to verify snapshot update recency. #64

wants to merge 1 commit into from

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Oct 19, 2023

No description provided.

TheBlueMatt
TheBlueMatt reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the point of this - it looks like this is testing the client side code, not the server-side code - does this belong in rust-lightning? What specifically is it testing?

src/tests/mod.rs
println!("UPDATE RESULT: {}", update_result);

// the update result must be a multiple of our snapshot granularity
assert_eq!(update_result % config::snapshot_generation_interval(), 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this spuriously fail if we ever change the interval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arik-so @TheBlueMatt