Enable using VssStore with VssHeaderProvider. #369
Conversation
G8XSU
commented
Oct 10, 2024
G8XSU
commented
- Enable using VssStore with VssHeaderProvider.
- Default to LnUrlJWT auth for using VSS.
| pub fn build_with_vss_store(&self, url: String, store_id: String) -> Result<Node, BuildError> { | ||
| use bitcoin::key::Secp256k1; | ||
|
|
||
| pub fn build_with_vss_store_and_header_provider( |
There was a problem hiding this comment.
I think we should expose three variants on the builder: a) with header based auth (which also would allow to leave them unset allowing unauthenticated use, e.g., for testing) b) Jwt-based auth c) custom authentication via dyn VssHeaderProvider
There was a problem hiding this comment.
Sure, I don't mind adding another method for fixed headers. It should be helpful for tests.
| })?; | ||
|
|
||
| let lnurl_auth_jwt_provider = | ||
| LnurlAuthToJwtProvider::new(lnurl_auth_xprv, lnurl_auth_server_url, fixed_headers) |
There was a problem hiding this comment.
I'm confused: the fixed HTTP header variant is unrelated to the JWT-based authentication, no? So shouldn't we here use the FixedHeaders to parametrize the client directly?
There was a problem hiding this comment.
This is to allow additional custom headers in case vss provider is using JWT-based auth.
Not entirely sure but I think one of client might want to use it.
|
Pushed 2 more commits but its not showing up since github is still processing them since 3 hrs: https://github.blog/changelog/2023-09-26-more-details-provided-when-a-pull-request-is-merged-indirectly-or-is-still-processing-updates/#pushed-commits-are-still-being-processed. |
Hmm, could you force-push once more? Can't review commits that aren't there 😁 |
|
Also needs a rebase to account for the yanked 0.0.124. |
