-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 0.0.121 #117
Merged
Merged
Update to 0.0.121 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this is generally unsafe, we have to do something for `CandidateRouteHop`, which is passed to the scorer. Because its incredibly performance-sensitive, forcing the bindings users to take a performance hit just to make the scoring interface marginally safer seems like a bad trade-off.
The fields themselves are already public, so there's not a lot of value for C users for these, but it avoids having to have this logic written out by hand in the Java bindings, which is nice.
Yet another macOS-is-randomly-broken case. Doesn't matter since we don't actually build release binaries on macOS anymore. Squashed the fixup with no changes, so going to go ahead and land. |
@TheBlueMatt Sorry for raising this too late, but it seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.