Update args on supertraits of supertraits when cloning trait impls #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning implementations of traits from in-crate structs, we forgot to update the arguments for supertraits of supertraits, causing methods on that trait to be called against the previous struct, not the cloned one. This was ultimately identified downstream in the Java bindings, fixes lightningdevkit/ldk-garbagecollected#138
tnull
reviewed
Oct 9, 2023
| writeln!(w, "\tnew_obj.{}{}.free = None;", pfx, t).unwrap(); | ||
| let tr = types.crate_types.traits.get(s).unwrap(); | ||
| let resolver = get_module_type_resolver!(s, types.crate_types); | ||
| seek_supertraits(w, &format!("{}.", t), tr, &resolver); |
There was a problem hiding this comment.
non-blocking nit: Would be a bit clearer if we made pfx an Option<&str> and adjusted the format string accordingly.
There was a problem hiding this comment.
That feels less readable to me - it's more code and not doing anything other than maintaining the prefix (which still can be arbitrarily long). Would you prefer a different variable name instead?
arik-so
approved these changes
Oct 9, 2023
tnull
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning implementations of traits from in-crate structs, we
forgot to update the arguments for supertraits of supertraits,
causing methods on that trait to be called against the previous
struct, not the cloned one.
This was ultimately identified downstream in the Java bindings,
fixes lightningdevkit/ldk-garbagecollected#138