Merge pull request #166 from lightning-js/dev

Release 1.4.2

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## v1.4.2
+
+_24 sept 2024_
+
+- Fixed timing issue with calculation of percentages
+- Improved check to see if object is a Blits component, so it's more robust in case of code minification
+
 ## v1.4.1
 
 _18 sept 2024_

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/blits",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "Blits: The Lightning 3 App Development Framework",
   "bin": "bin/index.js",
   "exports": {

src/component.js

@@ -260,6 +260,9 @@ const Component = (name = required('name'), config = required('config')) => {
   // during the code generation step
   factory.config = config
 
+  // To determine whether dynamic component is actual Blits component or not
+  factory[symbols.isComponent] = true
+
   return factory
 }
 

src/engines/L3/element.js

@@ -39,9 +39,9 @@ const parsePercentage = function (v, base) {
     return v
   } else if (v.indexOf('%') === v.length - 1) {
     return (
-      this.element.parent &&
-      this.element.parent[base] &&
-      this.element.parent[base] * (parseFloat(v) / 100)
+      (this.element.config.parent &&
+        (this.element.config.parent.node[base] || 0) * (parseFloat(v) / 100)) ||
+      0
     )
   }
   return v

src/lib/codegenerator/generator.js

@@ -234,7 +234,7 @@ const generateComponentCode = function (
       if(!component${counter}) {
         throw new Error('Component "${templateObject[Symbol.for('componentType')]}" not found')
       }
-    } else if(typeof componentType === 'function' && componentType.name === 'factory') {
+    } else if(typeof componentType === 'function' && componentType[Symbol.for('isComponent')] === true) {
       component${counter} = componentType
     }
 

src/lib/symbols.js

@@ -44,4 +44,6 @@ export default {
   slots: Symbol.for('slots'),
   // Symbol 'componentType' utilized within generated code
   componentType: Symbol.for('componentType'),
+  // Symbol 'isComponent' utilized within generated code
+  isComponent: Symbol.for('isComponent'),
 }