Optimized setting parent node by skipping getNodeById function.

lightning-js · Oct 11, 2023 · 6618e4e · 6618e4e
1 parent b956ddf
commit 6618e4e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/element.js b/src/element.js
@@ -54,9 +54,12 @@ const transformations = {
     'z' in props && (props.zIndex = props.z)
     delete props.z
   },
-  parentId(props) {
-    props.parent = props.parentId === 'root' ? renderer.root : renderer.getNodeById(props.parentId)
-    delete props.parentId
+  parent(props) {
+    if (props.parent === 'root') {
+      props.parent = renderer.root
+    } else {
+      props.parent = props.parent.node
+    }
   },
   color(props) {
     if (

diff --git a/src/lib/codegenerator/generator.js b/src/lib/codegenerator/generator.js
@@ -56,7 +56,7 @@ const generateElementCode = function (
 
   renderCode.push(`
     if(!${elm}) {
-      ${elm} = this.element({componentId: component.___id, parentId: parent && parent.nodeId || 'root'})
+      ${elm} = this.element({componentId: component.___id, parent: parent || 'root'})
     }
     const elementConfig${counter} = {}
   `)