Merge pull request #87 from suresh-gangumalla/fix/enable-children-com…

…p-to-destroy

Destroy hook in children components not invoked

src/lib/setup/base.js

@@ -272,11 +272,15 @@ export default (component, name) => {
 const deleteChildren = function (children) {
   for (let i = 0; i < children.length; i++) {
     if (!children[i]) return
-    if (Array.isArray(children[i])) {
-      deleteChildren(children[i])
-    } else if (children[i].destroy) {
+    // call destroy when method is available on child
+    if (children[i].destroy && typeof children[i].destroy === 'function') {
       children[i].destroy()
     }
+    // recursively call deleteChildren when it's an object of items (happens when using a forloop construct)
+    else if (Object.getPrototypeOf(children[i]) === Object.prototype) {
+      deleteChildren(Object.values(children[i]))
+    }
+
     children[i] = null
   }
 

src/router/router.js

@@ -253,13 +253,6 @@ const removeView = async (route, view, transition) => {
   if (route.options && route.options.keepAlive === true) {
     cacheMap.set(route, { view: view, focus: previousFocus })
   } else {
-    // remove and cleanup
-    for (let i = 0; i < view[symbols.children].length; i++) {
-      // if (view[symbols.children][i] && view[symbols.children][i].destroy) {
-      //   view[symbols.children][i].destroy()
-      view[symbols.children][i] = null
-      // }
-    }
     view.destroy()
     view = null
   }