Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching log4j version to v2.15.0 #888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YLcoding
Copy link

No description provided.

@vidhem
Copy link

vidhem commented Dec 18, 2021

Hi, can we merge this soon to patch the CVE? Also would it be better to bump to 2.17+ instead?

CC: @jekh

@@ -68,7 +68,7 @@

<maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>

<log4j.version>2.9.0</log4j.version>
<log4j.version>2.15.0</log4j.version>
Copy link

@twsheehan twsheehan Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @vidhem suggests; can we bump up to version 2.17.0 for the reason described:

The Log4j team has been made aware of a security vulnerability, CVE-2021-45105, that has been addressed in Log4j 2.17.0 for Java 8 and up.

I tested your patch locally @YLcoding with both versions 2.15.0 and 2.17.0 with both versions, all unit tests pass except for: net.lightbody.bmp.proxy.BindAddressTest.testClientBindAddressCannotConnect

java.lang.AssertionError: Expected exception: org.apache.http.conn.HttpHostConnectException

Evaluating localHostAddr = InetAddress.getLocalHost() does allow the HTTP client to connect to the proxy and I do not observe the expected UnknownHostException.

Copy link

@twsheehan twsheehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks all for the patch!

@rseemaa
Copy link

rseemaa commented Jun 14, 2024

where can I find the jar files for 2.17 release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants