-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-2001 - c-prefers-expanded-text utility breaks styling in page editor #689
Conversation
The following guidelines have been set by the owner of this repository:
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-2001 1 Successful Jobs:For more details click here. |
ci:test:relevant |
Jenkins Build:test-portal-source-format#8815 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-platform-experience#689 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - ilzamcmed > liferay-platform-experience - PR#689 - 2024-08-13[05:06:09] Testray Build ID:59776990 Testray Importer:publish-testray-report#33301 |
ci:test:relevant |
Jenkins Build:test-portal-acceptance-pullrequest(master)#4740 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-platform-experience#689 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - ilzamcmed > liferay-platform-experience - PR#689 - 2024-08-13[06:35:00] Testray Build ID:59891371 Testray Importer:publish-testray-report#33304 |
...or-web/src/main/resources/META-INF/resources/page_editor/app/components/ItemConfiguration.js
Show resolved
Hide resolved
ci:test:sf |
❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-2001 1 Failed Jobs:For more details click here.[exec] > Task :packageRunCheckFormat [exec] yarn run v1.13.0 [exec] \$ node-scripts check:ci [exec] [exec] ⚙️ Running preflight checks... [exec] [exec] ⚙️ Checking outdated tsconfig.json files ... [exec] [exec] ⚙️ Running TypeScript checks on modified files... [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers [exec] [exec] ⚙️ Running format checks on modified files... [exec] /opt/dev/projects/github/liferay-portal/modules/apps/layout/layout-content-page-editor-web/src/main/resources/META-INF/resources/page_editor/app/components/ItemConfiguration.js [exec] 1:1 error File has format errors. (format check) [exec] [exec] ✖ 1 problem (1 error, 0 warnings) [exec] [exec] [exec] ❌ CI checks failed. [exec] error Command failed with exit code 1. [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. [exec] [exec] > Task :packageRunCheckFormat FAILED [exec] Gradle build finished at 2024-08-14 12:31:09.180. [exec] [exec] [exec] FAILURE: Build failed with an exception. [exec] [exec] * What went wrong: [exec] Execution failed for task ':packageRunCheckFormat'. [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1 [exec] [exec] 3 actionable tasks: 2 executed, 1 up-to-date* Try: [exec] [exec] [exec] > Run with --info or --debug option to get more log output. [exec] > Run with --scan to get full insights. [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2024-08-14-05-30-58.html> Get more help at https://help.gradle.org. [exec] A fine-grained performance profile is available: use the --scan option. [exec] [exec] * Exception is: [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'. [exec] [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148) [exec] at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282) [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146) |
Jenkins Build:test-portal-source-format#6594 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-platform-experience#689 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - ilzamcmed > liferay-platform-experience - PR#689 - 2024-08-14[05:27:52] Testray Build ID:60960590 Testray Importer:publish-testray-report#25804 |
I am getting some errors while running |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-2001 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#8851 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-platform-experience#689 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - ilzamcmed > liferay-platform-experience - PR#689 - 2024-08-20[06:46:18] Testray Build ID:66479513 Testray Importer:publish-testray-report#33404 |
ci:test:relevant |
Jenkins Build:test-portal-acceptance-pullrequest(master)#10171 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-platform-experience#689 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - ilzamcmed > liferay-platform-experience - PR#689 - 2024-08-20[06:54:26] Testray Build ID:66557564 Testray Importer:publish-testray-report#22580 |
Thanks @ilzamcmed . In this case, I don't think we want to take this approach though. We shouldn't need a one off fix in a single component for this. Whatever our fix is it should be more global and ideally take place in Clay. I think the only fix we may need would be removing @pat270 is this really needed. In some basic testing it looks to me like it shouldn't be necessary. |
Thanks @ethib137! I thought this solution to be more of a specific change since the one we should fix on clay didn't have any definition with @marcoscv-work on the other PR. Removing the |
@ethib137 We can get rid of max-width: 100%. The reason why it's there is because This one gets tricky because of the Edit: I found the edge case. Changing We don't need Edit 2: Maybe we should consider removing |
This is looking closer to the right solution. Our tabs on multiple lines does not look good. That probably needs to be rethought from a design perspective. @pat270 what's the problem with just removing Also, it looks like cadmin is overriding c-prefers-expanded-text. In terms of removing c-inner from dxp, that's probably a good idea to create a ticket for it and add it to the backlog. |
@ethib137 @marcoscv-work gave us some styling options when tabs break to new line at liferay/clay#5622. The difficult part about this is targeting the styles to apply only when tabs have broke to new line. I tried to use container queries today, but it didn't get it to work yet. I think I might be able to get it to work with grid? The problem with container queries is that we need a fixed or percentage width on the element.
|
Hey @pat270 your gif looks like you're adding Screen.Recording.2024-08-23.at.2.57.56.PM.mov |
@ethib137 You're right, we can remove it. It doesn't impact anything. Are you ok with the text just breaking to new line? |
Yeah, I think text breaking to new line is fine. In most cases that's what you want. At some point we can work on a tabs improvement to fix that, but it's not high priority. |
@ilzamcmed I can make the change on Clay's side. I'm still trying to figure out how to switch the styles when tabs break to new line. |
@ilzamcmed we don't need to remove |
Okay.. so we should be able to close this PR then right? |
Thanks guys! 🎉 |
Jira ticket: https://liferay.atlassian.net/browse/LPD-2001
simplescreenrecorder-2024-08-19_14.32.05.mp4