Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-1230 Delete item action message text is not correct #4513

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thektan
Copy link

@thektan thektan commented Oct 23, 2024

https://liferay.atlassian.net/browse/LPD-1230

  • Fixes the Action delete modal description
  • Fixes the Visualization Mode delete modal title (previously said "Delete Filter")
Screenshot 2024-10-23 at 4 57 24 PM Screenshot 2024-10-23 at 4 58 20 PM

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e35662165e3a22f6407d8fff407424fd34f6cf5d

Sender Branch:

Branch Name: LPD-1230_DeleteItemActionMessageTextIsNotCorrect
Branch GIT ID: ee9a07f49c9dabdee2d5e2e9641b017cee67cbd4

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:50427719

@thektan
Copy link
Author

thektan commented Oct 24, 2024

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

Build started.

Jenkins is currently running tests in the relevant test suite.

Base Branch:

Branch Name: master

Job Summary:

Job Link: test-portal-acceptance-pullrequest(master)

For more details click here.

Copy link
Collaborator

@juanjofgliferay juanjofgliferay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants