forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-37264 Apply Root Model to the Data Set Object definition through the batch engine #4511
Draft
dsanz
wants to merge
3
commits into
liferay-frontend:master
Choose a base branch
from
dsanz:LPD-37264
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd an extra edge relation to keep root model constraints, which allows to keep the connections between data set and actions as optional
CI is automatically triggering the following test suites:
|
ci:test:playwright |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-37264 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#6323 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4511 Testray Routine:EE Pull Request Testray Build ID:49906704 Testray Importer:publish-testray-report#24571 |
liferay-continuous-integration
added
ci:test:playwright - failure
and removed
ci:test:playwright - pending
labels
Oct 23, 2024
Jenkins Build:test-portal-acceptance-pullrequest(master)#5398 Jenkins Report:jenkins-report.html Jenkins Suite:playwright Pull Request:liferay-frontend#4511 Testray Routine:EE Pull Request Testray Build:[master] ci:test:playwright - dsanz > liferay-frontend - PR#4511 - 2024-10-23[09:33:13] Testray Build ID:50063904 Testray Importer:publish-testray-report#34748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are adding root model capabilities to the Data Set Manager data model, created through a batch import process.
This entails:
edge
to be created, which are mandatory when connecting object entries. We use 2 existing connections to model "creation" and "item" actions, that are not mandatory. As we want to keep them like that, we need an extra connection, not used to fetch data.