-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-39583 - Check if selectedItem exists before referencing it #4510
base: master
Are you sure you want to change the base?
Conversation
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-39583 1 Successful Jobs:For more details click here. |
ci:test:relevant |
Jenkins Build:test-portal-source-format#5863 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4510 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - kresimir-coko > liferay-frontend - PR#4510 - 2024-10-23[08:23:00] Testray Build ID:49872379 Testray Importer:publish-testray-report#6614 |
✔️ ci:test:stable - 24 out of 24 jobs passed✔️ ci:test:relevant - 29 out of 29 jobs passed in 57 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 20c16b763e47400f6e4d7cc1f462a054278d1d4b ci:test:stable - 24 out of 24 jobs PASSED24 Successful Jobs:
ci:test:relevant - 29 out of 29 jobs PASSED29 Successful Jobs:
For more details click here.Test bundle downloads: |
Jenkins Build:test-portal-acceptance-pullrequest(master)#11513 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4510 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#4510 - 2024-10-23[08:41:34] Testray Build ID:49910415 Testray Importer:publish-testray-report#24917 |
Seems that the fix to the implementation was enough @dsanz |
@kresimir-coko Your fix is working, as it removes the errors that throws the component. However, I would say that there is still a hidden bug. It seems that the problem could be related with the Using the
|
Good catch @juanjofgliferay I'll improve the solution 👍 |
7703ec1
to
b5e749d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jira ticket
TranslationManager
Poshi tests were failing, I think I figured out why. The fix is in the commit, locally all tests pass. Time to see what CI has to say