LPD-39583 - Check if selectedItem exists before referencing it

[kresimir-coko]

Jira ticket

TranslationManager Poshi tests were failing, I think I figured out why. The fix is in the commit, locally all tests pass. Time to see what CI has to say

[liferay-continuous-integration]

CI is automatically triggering the following test suites:

•     ci:test:sf

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

Sender Branch:

Branch Name: LPD-39583
Branch GIT ID: 7703ec1715e36c277d5904f2e4f9badd6adda94b

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[kresimir-coko]

ci:test:relevant

[liferay-continuous-integration]

Jenkins Build:test-portal-source-format#5863

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4510

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - kresimir-coko > liferay-frontend - PR#4510 - 2024-10-23[08:23:00]

Testray Build ID:49872379

Testray Importer:publish-testray-report#6614

[liferay-continuous-integration]

✔️ ci:test:stable - 24 out of 24 jobs passed

✔️ ci:test:relevant - 29 out of 29 jobs passed in 57 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

Upstream Comparison:

Branch GIT ID: 20c16b763e47400f6e4d7cc1f462a054278d1d4b
Jenkins Build URL: EE Development Acceptance (master) - 940 - 2024-10-22[08:38:15]

ci:test:stable - 24 out of 24 jobs PASSED

24 Successful Jobs:

• central-requirements
  • central-requirements/0/0
• functional-smoke-tomcat90-mysql57_stable
  • functional-smoke-tomcat90-mysql57_stable/0/0
• functional-upgrade-tomcat90-mysql57_stable
  • functional-upgrade-tomcat90-mysql57_stable/0/0
  • functional-upgrade-tomcat90-mysql57_stable/0/1
  • functional-upgrade-tomcat90-mysql57_stable/0/2
• js-unit
  • js-unit/0/0
  • js-unit/1/0
• modules-compile
  • modules-compile/0/0
  • modules-compile/0/1
  • modules-compile/0/2
  • modules-compile/0/3
  • modules-compile/0/4
  • modules-compile/0/5
  • modules-compile/0/6
  • modules-compile/0/7
  • modules-compile/0/8
  • modules-compile/0/9
  • modules-compile/0/10
  • modules-compile/0/11
  • modules-compile/0/12
• modules-integration-mysql57_stable
  • modules-integration-mysql57_stable/0/0
• modules-unit_stable
  • modules-unit_stable/0/0
• playwright-js-tomcat90-mysql57_stable
  • playwright-js-tomcat90-mysql57_stable/0/0
• unit_stable
  • unit_stable/0/0

ci:test:relevant - 29 out of 29 jobs PASSED

29 Successful Jobs:

• test-portal-acceptance-pullrequest(master)
• central-requirements
  • central-requirements/0/0
• functional-smoke-tomcat90-mysql57_stable
  • functional-smoke-tomcat90-mysql57_stable/0/0
• functional-upgrade-tomcat90-mysql57_stable
  • functional-upgrade-tomcat90-mysql57_stable/0/0
  • functional-upgrade-tomcat90-mysql57_stable/0/1
  • functional-upgrade-tomcat90-mysql57_stable/0/2
• js-unit
  • js-unit/0/0
  • js-unit/1/0
• modules-compile
  • modules-compile/0/0
  • modules-compile/0/1
  • modules-compile/0/2
  • modules-compile/0/3
  • modules-compile/0/4
  • modules-compile/0/5
  • modules-compile/0/6
  • modules-compile/0/7
  • modules-compile/0/8
  • modules-compile/0/9
  • modules-compile/0/10
  • modules-compile/0/11
  • modules-compile/0/12
• modules-integration-mysql57
  • modules-integration-mysql57/0/0
• modules-integration-mysql57_stable
  • modules-integration-mysql57_stable/0/0
• modules-semantic-versioning
  • modules-semantic-versioning/0/0
• modules-unit
  • modules-unit/0/0
• modules-unit_stable
  • modules-unit_stable/0/0
• playwright-js-tomcat90-mysql57
  • playwright-js-tomcat90-mysql57/0/0
• playwright-js-tomcat90-mysql57_stable
  • playwright-js-tomcat90-mysql57_stable/0/0
• unit_stable
  • unit_stable/0/0

For more details click here.

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

[liferay-continuous-integration]

Jenkins Build:test-portal-acceptance-pullrequest(master)#11513

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#4510

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#4510 - 2024-10-23[08:41:34]

Testray Build ID:49910415

Testray Importer:publish-testray-report#24917

[kresimir-coko]

Seems that the fix to the implementation was enough @dsanz

[juanjofgliferay]

@kresimir-coko Your fix is working, as it removes the errors that throws the component. However, I would say that there is still a hidden bug.
In the first example of the React component (frontend-js-components-sample-web) the button does not show the flag, but it has selected a default language.

It seems that the problem could be related with the selectedItem of the component when adminMode is off, see https://github.com/liferay-frontend/liferay-portal/pull/4510/files#diff-12217acb262642b4fc9915a451195df883d248a1e003fadd9909426c5f0f2fe1R220

Using the defaultLanguageId as fallback seems to fix the component errors and it displays the flag.

   selectedItem={activeLocales.find(
	(locale) => locale.id === selectedLanguageId || locale.id === defaultLanguageId
   )}

[kresimir-coko]

Good catch @juanjofgliferay I'll improve the solution 👍

[juanjofgliferay]

LGTM