Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-40036 Fixed header should have exactly the same width than original header #4508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LPD-40036 Fixed header should have exactly the same width than original header #4508

wants to merge 1 commit into from
+6 −2

Conversation

antonio-ortega
Copy link
Collaborator

Hi,

This issue is happening in our search containers when we fixed the header... and our OS is configured to show scrollbars only during scrolling, as it happens by default in macOS. If you configure your setting to make scrollbars always present there is no issue.

The root cause is the container's width for fixed header (hidden initially and only present when you scroll down) is calculated considering remaining space when scrollbar is present, however original header's width is calculated when there is no scrollbar at all. Since they have different width they are not matching when we scroll down.
image

My solution is to be sure they both have the same width so they perfectly overlap when scrolling down.

Since this issue depends on OS settings, and as far as I know, only MacOS has a default setting causing this, I'm not adding any test.

Thanks.

Regards.

@antonio-ortega
LPD-40036 Fixed header should have exactly the same width than origin…
6fcb51f 
…al header. Otherwise they might not perfectly overlap when scrolling
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

Sender Branch:

Branch Name: LPD-40036
Branch GIT ID: 6fcb51f61bf926013e873acf9d6f9a8bebf86bd3

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@antonio-ortega
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 20 out of 23 jobs passed

❌ ci:test:relevant - 21 out of 27 jobs passed in 3 hours 14 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1407401_11511

Base Branch:

Branch Name: master
Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

Upstream Comparison:

Branch GIT ID: 20c16b763e47400f6e4d7cc1f462a054278d1d4b
Jenkins Build URL: EE Development Acceptance (master) - 940 - 2024-10-22[08:38:15]

ci:test:stable - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:
    ci:test:relevant - 21 out of 27 jobs PASSED

    6 Failed Jobs:

    21 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. modules-integration-mysql57_stable/0/0
        Build was aborted
        1. com.liferay.jenkins.JenkinsLogAsserterTest
        2. com.liferay.portal.dao.db.test.DBInspectorTest.testHasColumn - UNTESTED
        3. com.liferay.portal.dao.db.test.DBInspectorTest.testHasColumnNonexisting - UNTESTED
        4. ...
      2. modules-compile/0/0
        run-ant-target:
[beanshell] The properties for 'modules-compile/0/start.properties' cannot be found in /tmp/jenkins/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220877/build-database.json
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877/api/json?tree=actions%5Bparameters%5Bname%2Cvalue%5D%5D in 5 seconds
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877//api/json?tree=actions%5Bparameters%5B*%5D%5D in 5 seconds
[beanshell] Executing commands: ssh root@test-1-26 date +%s
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877//api/json?tree=result%2CqueueId%2Curl in 5 seconds
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877//api/json?tree=result%2CqueueId%2Curl in 5 seconds
[beanshell] Created cache file in /tmp/jenkins-cached-files/-978342110.txt
[beanshell] Created cache file in /tmp/jenkins-cached-files/-978342110.txt

        BUILD FAILED
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15367: The following error occurred while executing this line:
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-downstream.xml:5: The following error occurred while executing this line:
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-batch.xml:5: The following error occurred while executing this line:
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:11: Please set the property ${env.TOP_LEVEL_BUILD_NUMBER}.
      3. modules-compile/0/11
          at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
        
at org.apache.tools.ant.Task.perform(Task.java:350)
        
at java.util.Vector.forEach(Vector.java:1283)
        
at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
        
at net.sf.antcontrib.logic.IfTask.execute(IfTask.java:217)
        
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        
at java.lang.reflect.Method.invoke(Method.java:498)
        
at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
        
at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:155)
        
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299)
        
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
        
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        
at java.lang.reflect.Method.invoke(Method.java:498)
        
at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
        
at org.apache.tools.ant.Task.perform(Task.java:350)
        
at java.util.Vector.forEach(Vector.java:1283)
        
at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
        
at net.sf.antcontrib.logic.TryCatchTask$CatchBlock.execute(TryCatchTask.java:137)
        
at net.sf.antcontrib.logic.TryCatchTask.execute(TryCatchTask.java:225)
        
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299)
        
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
        
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        
at java.lang.reflect.Method.invoke(Method.java:498)
        
at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
        
at org.apache.tools.ant.Task.perform(Task.java:350)
        
at org.apache.tools.ant.Target.execute(Target.java:449)
        
at org.apache.tools.ant.Target.performTasks(Target.java:470)
        
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401)
        
at org.apache.tools.ant.Project.executeTarget(Project.java:1374)
        
at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
        
at org.apache.tools.ant.Project.executeTargets(Project.java:1264)
        
at org.apache.tools.ant.Main.runBuild(Main.java:818)
        
at org.apache.tools.ant.Main.startAnt(Main.java:223)
        
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
        
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
      4. semantic-versioning/0/0
        run-ant-target:
        
[beanshell] The properties for 'semantic-versioning/0/start.properties' cannot be found in /tmp/jenkins/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220707/build-database.json
        
[beanshell] Retrying ${dependencies.url}/archive/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220707api/json?tree=actions%5Bparameters%5Bname%2Cvalue%5D%5D in 5 seconds
        
[beanshell] Retrying ${dependencies.url}/archive/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220707api/json?tree=actions%5Bparameters%5B*%5D%5D in 5 seconds
        
[beanshell] Executing commands: ssh root@test-1-26 date +%s
        
[beanshell] Retrying ${dependencies.url}/archive/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220707api/json?tree=result%2CqueueId%2Curl in 5 seconds
        
[beanshell] Retrying ${dependencies.url}/archive/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220707api/json?tree=result%2CqueueId%2Curl in 5 seconds
        
[beanshell] Created cache file in /tmp/jenkins-cached-files/159246766.txt
        
[beanshell] Created cache file in /tmp/jenkins-cached-files/159246766.txt
        

        BUILD FAILED
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15367: The following error occurred while executing this line:
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-downstream.xml:5: The following error occurred while executing this line:
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-batch.xml:5: The following error occurred while executing this line:
        
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:11: Please set the property ${env.TOP_LEVEL_BUILD_NUMBER}.
      Failures in common with acceptance upstream results at 20c16b7:
      Test bundle downloads:

      @antonio-ortega
      Copy link
      Collaborator Author

      ci:reevaluate:1407401_11511

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is reevaluating the build with build ID: 1407401_11511 against the latest valid upstream results.

      @liferay-continuous-integration
      Copy link
      Collaborator

      Previous ci:test:relevantbuild was unsuccessfully reevaluated against more recent upstream results.

      ❌ ci:test:stable - 17 out of 20 jobs passed

      ❌ ci:test:relevant - 21 out of 27 jobs passed in 3 hours 37 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

      Upstream Comparison:

      Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954
      Jenkins Build URL: EE Development Acceptance (master) - 943 - 2024-10-23[07:21:16]

      ci:test:stable - 17 out of 20 jobs PASSED
      17 Successful Jobs:
        ci:test:relevant - 21 out of 27 jobs PASSED

        6 Failed Jobs:

        21 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          1. modules-integration-mysql57_stable/0/0
            Build was aborted
            1. com.liferay.jenkins.JenkinsLogAsserterTest
            2. com.liferay.portal.dao.db.test.DBInspectorTest.testHasColumn - UNTESTED
            3. com.liferay.portal.dao.db.test.DBInspectorTest.testHasColumnNonexisting - UNTESTED
            4. ...
          2. modules-compile/0/0
            run-ant-target:
[beanshell] The properties for 'modules-compile/0/start.properties' cannot be found in /tmp/jenkins/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220877/build-database.json
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877/api/json?tree=actions%5Bparameters%5Bname%2Cvalue%5D%5D in 5 seconds
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877//api/json?tree=actions%5Bparameters%5B*%5D%5D in 5 seconds
[beanshell] Executing commands: ssh root@test-1-26 date +%s
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877//api/json?tree=result%2CqueueId%2Curl in 5 seconds
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220877//api/json?tree=result%2CqueueId%2Curl in 5 seconds
[beanshell] Created cache file in /tmp/jenkins-cached-files/-978342110.txt
[beanshell] Created cache file in /tmp/jenkins-cached-files/-978342110.txt

            BUILD FAILED
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15367: The following error occurred while executing this line:
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-downstream.xml:5: The following error occurred while executing this line:
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-batch.xml:5: The following error occurred while executing this line:
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:11: Please set the property ${env.TOP_LEVEL_BUILD_NUMBER}.
          3. modules-compile/0/11
              at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
            
at org.apache.tools.ant.Task.perform(Task.java:350)
            
at java.util.Vector.forEach(Vector.java:1283)
            
at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
            
at net.sf.antcontrib.logic.IfTask.execute(IfTask.java:217)
            
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
            
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            
at java.lang.reflect.Method.invoke(Method.java:498)
            
at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
            
at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:155)
            
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299)
            
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
            
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            
at java.lang.reflect.Method.invoke(Method.java:498)
            
at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
            
at org.apache.tools.ant.Task.perform(Task.java:350)
            
at java.util.Vector.forEach(Vector.java:1283)
            
at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
            
at net.sf.antcontrib.logic.TryCatchTask$CatchBlock.execute(TryCatchTask.java:137)
            
at net.sf.antcontrib.logic.TryCatchTask.execute(TryCatchTask.java:225)
            
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299)
            
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
            
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            
at java.lang.reflect.Method.invoke(Method.java:498)
            
at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
            
at org.apache.tools.ant.Task.perform(Task.java:350)
            
at org.apache.tools.ant.Target.execute(Target.java:449)
            
at org.apache.tools.ant.Target.performTasks(Target.java:470)
            
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401)
            
at org.apache.tools.ant.Project.executeTarget(Project.java:1374)
            
at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
            
at org.apache.tools.ant.Project.executeTargets(Project.java:1264)
            
at org.apache.tools.ant.Main.runBuild(Main.java:818)
            
at org.apache.tools.ant.Main.startAnt(Main.java:223)
            
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
            
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
          4. semantic-versioning/0/0
            run-ant-target:
            
[beanshell] The properties for 'semantic-versioning/0/start.properties' cannot be found in /tmp/jenkins/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/1220707/build-database.json
            
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220707/api/json?tree=actions%5Bparameters%5Bname%2Cvalue%5D%5D in 5 seconds
            
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220707//api/json?tree=actions%5Bparameters%5B*%5D%5D in 5 seconds
            
[beanshell] Executing commands: ssh root@test-1-26 date +%s
            
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220707//api/json?tree=result%2CqueueId%2Curl in 5 seconds
            
[beanshell] Retrying http://test-1-26/job/test-portal-acceptance-pullrequest-downstream(master)/1220707//api/json?tree=result%2CqueueId%2Curl in 5 seconds
            
[beanshell] Created cache file in /tmp/jenkins-cached-files/159246766.txt
            
[beanshell] Created cache file in /tmp/jenkins-cached-files/159246766.txt
            

            BUILD FAILED
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15367: The following error occurred while executing this line:
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-downstream.xml:5: The following error occurred while executing this line:
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-batch.xml:5: The following error occurred while executing this line:
            
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:11: Please set the property ${env.TOP_LEVEL_BUILD_NUMBER}.
          Failures in common with acceptance upstream results at 75cdfe6:

          @antonio-ortega
          Copy link
          Collaborator Author

          ci:test:relevant

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Reviewers
          No reviews
          Assignees
          No one assigned
          Labels
          ci:test:relevant - failure ci:test:sf - success ci:test:stable - failure
          Projects
          None yet
          Milestone
          No milestone
          Development

          Successfully merging this pull request may close these issues.
          2 participants
          @antonio-ortega @liferay-continuous-integration