-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-40036 Fixed header should have exactly the same width than original header #4508
base: master
Are you sure you want to change the base?
Conversation
…al header. Otherwise they might not perfectly overlap when scrolling
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-40036 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#9234 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4508 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4508 - 2024-10-23[03:10:25] Testray Build ID:49788898 Testray Importer:publish-testray-report#34737 |
ci:test:relevant |
❌ ci:test:stable - 20 out of 23 jobs passed❌ ci:test:relevant - 21 out of 27 jobs passed in 3 hours 14 minutesClick here for more details.This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result: ci:reevaluate:1407401_11511 Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 20c16b763e47400f6e4d7cc1f462a054278d1d4b ci:test:stable - 20 out of 23 jobs PASSED3 Failed Jobs:
20 Successful Jobs:ci:test:relevant - 21 out of 27 jobs PASSED6 Failed Jobs:
21 Successful Jobs:For more details click here.Failures unique to this pull:
Test bundle downloads: |
ci:reevaluate:1407401_11511 |
CI is reevaluating the build with build ID: |
Previous ❌ ci:test:stable - 17 out of 20 jobs passed❌ ci:test:relevant - 21 out of 27 jobs passed in 3 hours 37 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954 ci:test:stable - 17 out of 20 jobs PASSED3 Failed Jobs:
17 Successful Jobs:ci:test:relevant - 21 out of 27 jobs PASSED6 Failed Jobs:
21 Successful Jobs:For more details click here.Failures unique to this pull:
|
ci:test:relevant |
Hi,
This issue is happening in our search containers when we fixed the header... and our OS is configured to show scrollbars only during scrolling, as it happens by default in macOS. If you configure your setting to make scrollbars always present there is no issue.
The root cause is the container's width for fixed header (hidden initially and only present when you scroll down) is calculated considering remaining space when scrollbar is present, however original header's width is calculated when there is no scrollbar at all. Since they have different width they are not matching when we scroll down.
My solution is to be sure they both have the same width so they perfectly overlap when scrolling down.
Since this issue depends on OS settings, and as far as I know, only MacOS has a default setting causing this, I'm not adding any test.
Thanks.
Regards.