-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-37310 Adjsut cookieBanner playwright test #4501
base: master
Are you sure you want to change the base?
LPD-37310 Adjsut cookieBanner playwright test #4501
Conversation
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-37310 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#10387 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4501 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - fortunatomaldonado > liferay-frontend - PR#4501 - 2024-10-18[13:44:25] Testray Build ID:46502181 Testray Importer:publish-testray-report#39645 |
ci:test:relevant |
Build completed.Jenkins URL: test-portal-acceptance-pullrequest(master) The Please use |
Jenkins Build:test-portal-acceptance-pullrequest(master)#6874 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4501 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - fortunatomaldonado > liferay-frontend - PR#4501 - 2024-10-18[13:53:11] Testray Build ID:46502192 Testray Importer:publish-testray-report#15066 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fortunatomaldonado please see comments inline
@@ -52,7 +54,6 @@ test('@LPD-25701 Cookie Banner Script', async ({ | |||
await htmlExample.waitFor({state: 'visible'}); | |||
await htmlExample.click(); | |||
await htmlExample.click(); | |||
await htmlExample.click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You said in #4190 (comment) that triple click is the only way to edit. What changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this section is flaky as well and I'm thinking of redoing this a different way in order to prevent all the flaky tasks.
await waitForAlert( | ||
page, | ||
`Success:Your request completed successfully.` | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change is needed. waitForAlert
defaults to this text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this too but was failing locally without it until I changed it. I'll revert it and see if I get any further errors.
await page.goto(layout.friendlyURL); | ||
await page.goto(layout.friendlyUrlPath); | ||
|
||
await page.locator('#content').waitFor({state: 'visible'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, can we just await edit button?
const editButton = await page.getByRole('link', {name: 'Edit'});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also flaky it seems. It get stuck not finding the Edit button. Trying to avoid this.
https://liferay.atlassian.net/browse/LPD-37310
Trying to fix flaky playwright test.
Let me know if there should be any changes.
Thank you!