-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-194344 Scrape the spritemap and add RequiredMark for required inputs #3635
Conversation
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-194344 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#7254 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#3635 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - kresimir-coko > liferay-frontend - PR#3635 - 2023-09-04[00:52:25] Testray Importer:publish-testray-report#3621 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#1873 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3635 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#3635 - 2023-09-04[01:46:39] Testray Importer:publish-testray-report#26914 |
Hey @kresimir-coko the failures are not related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kresimir-coko please see comments inline.
This will have conflicts with #3639, but that's fine. This one is likely to be the first one merged.
...et/frontend-data-set-views-web/src/main/resources/META-INF/resources/js/fds_view/Actions.tsx
Show resolved
Hide resolved
...et/frontend-data-set-views-web/src/main/resources/META-INF/resources/js/fds_view/Actions.tsx
Outdated
Show resolved
Hide resolved
...et/frontend-data-set-views-web/src/main/resources/META-INF/resources/js/fds_view/Actions.tsx
Show resolved
Hide resolved
49c0926
to
56c0a7c
Compare
I've rebased and force-pushed the changes, nothing significant but it covers all your comments @markocikos I think this should be forwardable, thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✨
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#5832 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3635 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#3635 - 2023-09-07[03:34:47] Testray Importer:publish-testray-report#10680 |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#1935 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3635 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#3635 - 2023-09-07[08:19:57] Testray Importer:publish-testray-report#27049 |
ci:forward:force |
1 similar comment
ci:forward:force |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously completed test suites:
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously completed test suites:
|
All required test suite(s) completed. |
Error has occurred while attempting to forward pull request to |
1 similar comment
Error has occurred while attempting to forward pull request to |
Pull request will not be forwarded to |
manual forward: brianchandotcom#140463 |
Continuation of brianchandotcom#139849
A proper variant of #3622
Reason for a new PR is that a lot of changes happened in the meanwhile (mostly by @thektan), and conflict resolution.
In this PR I am doing the following:
spritemap
from the backend to ourActions
componentspritemap
in aClaySelect
that offers the scraped iconsClaySelect
RequiredMark
component to mark inputs as required