-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-40156 We should check if the toggle switch is already checked or not in WikiPortlet.macro's enableWiki() #6031
base: master
Are you sure you want to change the base?
Conversation
CI is automatically triggering the following test suites:
|
ci:test:headless-functional |
✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-40156 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#6276 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-content-management#6031 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - Mikellorza > liferay-content-management - PR#6031 - 2024-10-24[03:10:17] Testray Build ID:50637153 Testray Importer:publish-testray-report#4117 |
Build started.Jenkins is currently running tests in the Base Branch:Branch Name: master Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
ci:content:management |
ci:test:content:management |
The test suite specified is not a valid test suite. ci:test[:suite]:dryrunGenerate the job summary of the specified test suite based on the pull request changes. This command will not test the pull request. ci:test[:suite][:SHA|nocompile|norebase|gist-SHA]Test the pull request. Optionally specify the name of the test suite and/or optionally specify the upstream SHA to test against or use "nocompile" to test with a prebuilt bundle or use "norebase" to test without rebasing. Available test suites:
|
ci:test:content-management |
Build started.Jenkins is currently running tests in the Base Branch:Branch Name: master Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
What is this trying to solve?
https://liferay.atlassian.net/browse/LPD-40156
Some staging tests are being affected by enable wiki macro like this one. So this PR is to tmprove enable wiki macro in order to take into account some use cases when:
How am I fixing it?
Check if there is a disabled wiki feature flag to enable it and go back to home page
How can you verify that it works?
No test needed because this is to improve our tests. Execute ci:test:headless-functional to see if this change fix this staging issue.