LPD-40116 on this case the friendlyURLPosition should match with the one with # because can be mixed #6030
+75
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
|
ci:test:content-management |
|
ci:help |
Available CI commands:ci:closeClose the pull request. ci:forward[:force] Test the pull request and forward the pull request to ci:merge[:force]Merge in the changes from the subrepo. All tests must pass before this command will successfully run. Optionally use the force flag to bypass failed tests. ci:reevaluate:[buildID]Reevaluate the pull request result from a generated build ID. ci:reopenReopen the pull request. ci:report:[testrayBuildID]Generates a report of test results categorized into unique and nonunique test failures based on the Testray Analysis Tool. ci:stop[:suite]Stop all currrently running tests. Optionally specify the name of the test suite. ci:test[:suite]:dryrunGenerate the job summary of the specified test suite based on the pull request changes. This command will not test the pull request. ci:test[:suite][:SHA|nocompile|norebase|gist-SHA]Test the pull request. Optionally specify the name of the test suite and/or optionally specify the upstream SHA to test against or use "nocompile" to test with a prebuilt bundle or use "norebase" to test without rebasing. Available test suites:
For more details, see CI GitHub Commands |
|
ci:test:export-import |
jkappler
reviewed
Oct 23, 2024
...ay/exportimport/internal/content/processor/test/DefaultExportImportContentProcessorTest.java
Outdated
Show resolved
Hide resolved
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-40116 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#9236 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-content-management#6030 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - AliciaGarciaGarcia > liferay-content-management - PR#6030 - 2024-10-23[10:31:06] Testray Build ID:49946130 Testray Importer:publish-testray-report#34743 |
liferay-continuous-integration
added
ci:test:export-import - success
and removed
ci:test:export-import - pending
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#5400 Jenkins Report:jenkins-report.html Jenkins Suite:content-management Pull Request:liferay-content-management#6030 Testray Routine:EE Pull Request Testray Build:[master] ci:test:content-management - AliciaGarciaGarcia > liferay-content-management - PR#6030 - 2024-10-23[10:32:12] Testray Build ID:50171385 Testray Importer:publish-testray-report#34750 |
|
ci:report:50171385 |
Build completed.Testray CSV has been generated successfully for testrayBuildID: 50171385. Job Link: generate-testray-csv Testray CSV Link: testray-results-50171385.csv |
liferay-continuous-integration
added
ci:test - success
and removed
ci:test - pending
labels
…ation when the links are mixed AND the old one, the one inserted with the UUID is on the trash.
…one with # because can be mixed
AliciaGarciaGarcia
force-pushed
the
LPD-40116
branch
from
7964a7b
to
1cbdf86
Compare
|
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-40116 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#8177 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-content-management#6030 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - AliciaGarciaGarcia > liferay-content-management - PR#6030 - 2024-10-24[00:24:28] Testray Build ID:50556531 Testray Importer:publish-testray-report#4551 |
|
ci:test:content-management |
jkappler
approved these changes
Oct 24, 2024
|
That's why I was not 100% sure @AliciaGarciaGarcia :P |
that's me the 100% of the time |
|
ci:test:relevant |
Build started.Jenkins is currently running tests in the Base Branch:Branch Name: master Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
Build started.Jenkins is currently running tests in the Base Branch:Branch Name: master Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LPD-40116 Importation fails when on a web content with 2 links with ONE of the on trash
What is this trying to solve?
https://liferay.atlassian.net/browse/LPD-40116
On some cases, the importation and exportation fails, it happens when the links are mixed AND the old one, the one inserted with the UUID, the file is on the trash.
How am I fixing it?
As the filters can be mixed we should check the exact characteres to find.
How can you verify that it works?
Run the included automated tests.
Commits