Remove comparable constraint from DedupBy #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't see any reason for DedupBy to require elements in the slice to be comparable, since the comparison is done by the function. This change relaxes the `comparable` constraint and adds a test case to prove that non-comparable types can be deduped.
|
Thank you! You're right, it looks like a copy-paste of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't see any reason for DedupBy to require elements in the slice to be comparable, since the comparison is done by the function.
This change relaxes the
comparableconstraint and adds a test case to prove that non-comparable types can be deduped.The test case is a bit silly, but it's easy to imagine wanting to dedup structs with slices in them and needing this (which is
what I needed).