refactor: make PgnTreeView independent of the AnalysisController #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-anders
force-pushed
the
treeViewInterface
branch
from
8f6ffaf
to
1edbfc5
Compare
tom-anders
commented
Oct 8, 2024
| @@ -300,7 +300,7 @@ void main() { | |||
|
|
|||
| await tester.tap(find.byKey(const Key('goto-previous'))); | |||
| // need to wait for current move change debounce delay | |||
| await tester.pump(const Duration(milliseconds: 200)); | |||
| await tester.pumpAndSettle(const Duration(milliseconds: 200)); | |||
There was a problem hiding this comment.
not 100% sure why pump() worked fine before and then with this commit pumpAndSettle() is needed - but with only pump() the Timer behind the debouncer never calls it callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Most of the file should be moved to something like
src/lib/view/pgn/tree_view.dart, but I have not done that yet to make reviewing easier. I'd push a commit that does this once the rest of the code looks good to you