Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid needle defaults error #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jfsimon
Copy link

@jfsimon jfsimon commented May 7, 2019

The compressed and rejectUnauthorized options are not allowed in needle.defaults. They're respectively HttpHeader (https://github.com/tomas/needle#http-header-options) and HttpRequest (https://github.com/tomas/needle#nodejs-tls-options) options.

Since v2.3.1, needle throws an error because of these 2 options (https://github.com/tomas/needle/blob/master/lib/needle.js#L775), I guess they were just noop before that. Unit tests are failing with latest version of needle without this patch.

@czosel
Copy link

czosel commented Feb 4, 2020

@rchipka I just ran into this as well. Is there anything blocking this? It would be great to get this merged 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants