Update froidure-pin-hpp for v1/3 #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
commented
Nov 1, 2024
Comment on lines
+86
to
+103
| # The following is kind of ridiculous, I'm sure there must be a better way | ||
| try: | ||
| sig = inspect.signature(func) | ||
| sig_str = str(inspect.signature(func)) | ||
| if sig_str.startswith("(self"): | ||
| params = sig_str.split(",") | ||
| if len(params) == 1 or params[1] != " *args": | ||
| sig = sig.replace( | ||
| parameters=( | ||
| inspect.Parameter( | ||
| "dummy", inspect.Parameter.POSITIONAL_ONLY | ||
| ), | ||
| ) | ||
| + tuple(val for val in sig.parameters.values()) | ||
| ) | ||
| wrapper.__signature__ = sig | ||
| except ValueError: | ||
| pass |
There was a problem hiding this comment.
@Joseph-Edwards the ridiculous fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires the corresponding one in libsemigroups to be merged first, and also for some of the tests to be adjusted.