Skip to content

Commit

Permalink
Rename VERSION to .VERSION
Browse files Browse the repository at this point in the history
The reason for this change is that "version" is a C++ standard library
header file from C++20 onwards, and the file VERSION can be confused
with this header when trying to "#include <version>". Even if there are
no explicit "#include <version>" in HPCombi, some standard library files
include "version" and then fail to compile if there's another file named
"VERSION" in the include path.
  • Loading branch information
james-d-mitchell committed Oct 21, 2023
1 parent b6186ec commit 710d756
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ ENDIF(BUILD_TESTING)
#####################
# config.h file stuff
configure_file(${CMAKE_SOURCE_DIR}/config.h.in ${CMAKE_BINARY_DIR}/HPCombi-config.h)
configure_file(${CMAKE_SOURCE_DIR}/VERSION.in ${CMAKE_BINARY_DIR}/VERSION)
configure_file(${CMAKE_SOURCE_DIR}/.VERSION.in ${CMAKE_BINARY_DIR}/.VERSION)

set(AUTOGENERATED_WARNING "WARNING: THIS IS A CMAKE AUTO-GENERATED FILE.")

Expand All @@ -151,7 +151,7 @@ foreach(f ${install_misc})
DESTINATION share/${CMAKE_PROJECT_NAME})
endforeach(f)

install (FILES ${CMAKE_CURRENT_BINARY_DIR}/VERSION DESTINATION ".")
install (FILES ${CMAKE_CURRENT_BINARY_DIR}/.VERSION DESTINATION ".")

install (FILES ${CMAKE_CURRENT_BINARY_DIR}/HPCombi-config.h
DESTINATION include/${CMAKE_PROJECT_NAME})
Expand Down

0 comments on commit 710d756

Please sign in to comment.