Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SDL_wasapi_win32 into SDL_wasapi #11431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lzard
Copy link
Contributor

@Lzard Lzard commented Nov 8, 2024

Moves code from SDL_wasapi_win32.c into SDL_wasapi.c, following support removal of WinRT.

/* !!! FIXME: merge this all into SDL_wasapi.c, now that WinRT is gone.
This is code that Windows uses to talk to WASAPI-related system APIs.
This is for non-WinRT desktop apps. The C++/CX implementation of these
functions, exclusive to WinRT, are in SDL_wasapi_winrt.cpp.
The code in SDL_wasapi.c is used by both standard Windows and WinRT builds
to deal with audio and calls into these functions. */

@slouken slouken requested a review from icculus November 8, 2024 15:02
@slouken slouken added this to the 3.2.0 milestone Nov 8, 2024
@icculus
Copy link
Collaborator

icculus commented Nov 12, 2024

This is something I wanted to do but didn't have time to clean up, so I'm 100% okay with this PR.

Let's definitely decide we aren't reverting #10724 before we merge this, but otherwise I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants