Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP: Allow building tests in parallel #11390

Merged

Conversation

sharkwouter
Copy link
Collaborator

Without this change using the -j flag while building the tests causes errors.

Description

The PSPSDK has been updated to allow for setting the target directory of EBOOT.PBP file. We can use this to make it possible to use the -j flag while building them. Right now this still causes errors.

I'll see if I can do the same for SDL3

Existing Issue(s)

@sharkwouter sharkwouter linked an issue Nov 1, 2024 that may be closed by this pull request
@icculus icculus merged commit 7cbb131 into libsdl-org:SDL2 Nov 1, 2024
40 checks passed
@sharkwouter sharkwouter deleted the allow-building-tests-in-parallel branch November 1, 2024 15:57
@madebr
Copy link
Contributor

madebr commented Nov 1, 2024

I don't think parallel build are completely fixed.
https://github.com/madebr/SDL/actions/runs/11632039753/job/32394428882#step:24:373

ninja: job failed: : && /usr/local/pspdev/bin/psp-gcc -I/usr/local/pspdev/psp/include -I/usr/local/pspdev/psp/sdk/include -DPSP -O2 -g -DNDEBUG -L/usr/local/pspdev/lib -L/usr/local/pspdev/psp/lib -L/usr/local/pspdev/psp/sdk/lib examples/CMakeFiles/camera-read-and-draw.dir/camera/01-read-and-draw/read-and-draw.c.obj -o examples/camera-read-and-draw  libSDL3.a  -lGL  -lm  -lGL  -lpspvram  -lpspaudio  -lpspvfpu  -lpspdisplay  -lpspgu  -lpspge  -lpsphprm  -lpspctrl  -lpsppower && cd /__w/SDL/SDL/build/examples && /usr/bin/cmake -E cmake_echo_color --cyan Not\ stripping\ binary\ for\ target\ camera-read-and-draw,\ build\ type\ is\ RelWithDebInfo. && cd /__w/SDL/SDL/build/examples && /usr/local/pspdev/bin/psp-fixup-imports /__w/SDL/SDL/build/examples/camera-read-and-draw && cd /__w/SDL/SDL/build/examples && /usr/bin/cmake -E cmake_echo_color --cyan Not\ building\ PRX\ for\ target\ camera-read-and-draw && cd /__w/SDL/SDL/build/examples && /usr/local/pspdev/bin/mksfoex -d MEMSIZE=1 -s APP_VER= SDL-camera-read-and-draw /__w/SDL/SDL/build/examples/PARAM.SFO && cd /__w/SDL/SDL/build/examples && /usr/local/pspdev/bin/pack-pbp /__w/SDL/SDL/build/examples/EBOOT.PBP /__w/SDL/SDL/build/examples/PARAM.SFO NULL NULL NULL NULL NULL /__w/SDL/SDL/build/examples/camera-read-and-draw NULL && cd /__w/SDL/SDL/build/examples && /usr/bin/cmake -E remove /__w/SDL/SDL/build/examples/PARAM.SFO && cd /__w/SDL/SDL/build/examples && /usr/bin/cmake -E cmake_echo_color --cyan EBOOT.PBP\ file\ created\ for\ target\ camera-read-and-draw. && cd /__w/SDL/SDL/build/examples && /usr/bin/cmake -E make_directory /__w/SDL/SDL/build/examples/sdl-camera-read-and-draw && cd /__w/SDL/SDL/build/examples && /usr/bin/cmake -E rename /__w/SDL/SDL/build/examples/EBOOT.PBP /__w/SDL/SDL/build/examples/sdl-camera-read-and-draw/EBOOT.PBP && cd /__w/SDL/SDL/build/examples && /usr/bin/cmake -E remove /__w/SDL/SDL/build/examples/PARAM.SFO
Not stripping binary for target camera-read-and-draw, build type is RelWithDebInfo.
Not building PRX for target camera-read-and-draw
[0]        360 bytes | /__w/SDL/SDL/build/examples/PARAM.SFO
ERROR: Could not open the file. (/__w/SDL/SDL/build/examples/PARAM.SFO)

Apply this patch to enable parallel builds on ci.

@sharkwouter
Copy link
Collaborator Author

I'll take a look, see if I can fix it.

@sharkwouter
Copy link
Collaborator Author

@madebr I don't understand, that workflow is failing while doing things that are not in the CMakeLists.txt file after merging this PR.

@madebr
Copy link
Contributor

madebr commented Nov 1, 2024

My logs look similar to the logs of the most recent run of libsdl-org/SDL's main branch?
What difference are you seeing?
Only thing my patch does, is remove the -j1 while building.

@madebr
Copy link
Contributor

madebr commented Nov 1, 2024

I think the issue with SDL3 is that the examples directory contains a copy of the CMakeLists.txt of tests

@sharkwouter
Copy link
Collaborator Author

Oh, I see. I did not fix this same issue for examples. I wasn't aware that worked the same way.

@sharkwouter
Copy link
Collaborator Author

@madebr I made another PR which fixes this: #11392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating PSP EBOOTs fails in parallel builds
3 participants