-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[emscripten] Fixes for data addresses above 2gb #11127
Conversation
This includes both wasm64 and wasm32 when addressing more than 2gb of memory. Fixes: libsdl-org#9052
I did this work against the SDL2 branch so that I could test it in the emscripten repo. Would it be reasonable to land this here first and the forward-port the patch to SDL3(main)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's fine. These changes look good to me, @icculus?
I'll merge this into SDL3 after dinner, if no one else beats me to it. |
Okay, merged to SDL3 in 02434cd, thanks! |
Is there any chance that an SDL2 release or tag is coming any time soon? Emscripten is currently setup to pull from a tag in this repo and I'd love to pull in these changes. Perhaps you could do a "prerelease" tag? |
I just pulled these changes into the release-2.30.x branch, which will be released on 11/1. You're welcome to use that as a prerelease tag if you want. It's getting minimal safe changes, so it should be fine to use until the 2.32 release. |
Any chance you could tag |
No, that's not how that works. |
This is in anticipation of libsdl-org/SDL#11127 landing in the next SDL2 release.
This is in anticipation of libsdl-org/SDL#11127 landing in the next SDL2 release.
This is in anticipation of libsdl-org/SDL#11127 landing in the next SDL2 release.
This is in anticipation of libsdl-org/SDL#11127 landing in the next SDL2 release.
This includes both wasm64 and wasm32 when addressing more than 2gb of memory.
Fixes: #9052