Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL 2.30.x Vita Touch broken #11441

Open
rsn8887 opened this issue Nov 10, 2024 · 2 comments
Open

SDL 2.30.x Vita Touch broken #11441

rsn8887 opened this issue Nov 10, 2024 · 2 comments

Comments

@rsn8887
Copy link

rsn8887 commented Nov 10, 2024

This commit broke front panel touch on Vita:
847a6cc

You changed the Touch_ID only in one place, but you also have to change the other instructions in the code in these places:

SDL_SendTouch((SDL_TouchID)port,

SDL_SendTouchMotion((SDL_TouchID)port,

SDL_SendTouch((SDL_TouchID)port,

(SDL_TouchID)port should be (SDL_TouchID)(port + 1)

Please test next time.

I'd rather say that 847a6cc

should be reverted. Changing ports like that breaks every single Vita app that uses Touch_ID, and is an API-breaking change that should be made in SDL3, not SDL2.

@Wohlstand
Copy link
Contributor

Wohlstand commented Nov 10, 2024

I changed that because this was actually a bug that violates of SDL2's specification on the touch device retrieving function where 0 return means an error, not an actual device, and that confuses the universal code (at my program was actual condition that checks for 0, and if 0 - an error, that happen on every platform, and on Vita this was set wrong, so, because of that, back touch worked, but front touch didn't, and therefore, because of that, I had to set a workaround to don't use the 0 check on Vita exclusively).

Anyway, thanks for the catch, this probably should be fixed where that thing is missed up.

Changing ports like that breaks every single Vita app that uses Touch_ID

Only apps that do use the raw touch ID instead of requesting touch IDs via function (which is generally mistake if develop program for general use on multiple platforms, not for Vita exclusively).

@rsn8887
Copy link
Author

rsn8887 commented Nov 10, 2024

Ok I made a PR that I think fixes this issue the correct way:
#11442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants