Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SDL_vitatouch.c: Fixed the incorrect touch device IDs
- Begining of device ID with 0 violates the SDL's specification that means the 0 is an error, invalid, failure, etc. But on Vita here it's an actual device... - Replacing 0 and 1 with 1 and 2 to resolve this violation. (cherry picked from commit dd6c663)
- Loading branch information
847a6cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this at all?
It is not enough to make this change only. You also have to send the correct touch_ID:
SDL_SendTouchMotion((SDL_TouchID)port,...
Is wrong, it should be port + 1 there.
847a6cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, a good note, I tested the thing on my end, and it worked, but I guess, the thing wasn't properly tested in this case, thanks for this catch!
847a6cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encountered the same issue, and I think that this commit should not be merged into 2.30.x. After checking with other devices under 2.30.x (such as n3ds), the TouchID still starts from 0.
Is it possible that this is due to a change in SDL3 being mistakenly merged into SDL2?