Enable multitap (multiplayer5) if a button is pressed on a controller other than 1 or 2 #12
Conversation
… other than the first two.
|
I think a better way to implement this would be thru a core option. |
|
That would probably be a more elegant solution. However, the concern for me (and perhaps with other users) with simply enabling/disabled multitap via a core option is that now you have to go through all your ROMs and enable the option for multitap on ROMs that will use it. This wouldn't be difficult but would be a little time consuming. I'm not familiar with the nature of core options but perhaps the multitap option could be one of three: disabled/enabled/auto where the auto option is how I've implemented it. |
|
not really, core options by default are per-core, unless you create a core options file for a particular game |
|
I've read somewhere that some games will not work if Multitap is connected/enabled, though I don't know which games these are so haven't been able to test it. If that's true then you wouldn't want MT enabled for all games and you don't want it disabled for games that use it. That's the reason I did it the way I did instead of just always enabling it. |
|
Also I found such a game. SMW2 Yoshi's Island will not work if multitap is enabled. I found a bug that caused this game to not run properly, which I fixed in my fork. |
|
Core options can be overriden to on a per-game basis too. |
Code was already in place for multitap support (called multiplayer5 in the code) but it was not enabled. Since there is no way to query retroarch for the number of controllers connected, I implemented a change where the multitap becomes enabled if a button is pressed on any controller other than 1 or 2. Note that I didn't simply enable multitap all the time because I've heard that some 1-2 player games will not work properly with multitap enabled, though I don't know which games these are.