Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu Core support #59

Merged
merged 5 commits into from
Aug 25, 2024
Merged

Ubuntu Core support #59

merged 5 commits into from
Aug 25, 2024

Conversation

viachaslavic
Copy link
Contributor

@viachaslavic viachaslavic commented Aug 15, 2024 •
edited
Loading

Description

Add initial support the daemon mode based on the iot-example-graphical-snap template, but with the support of both Wayland and KMS/DRM.

Related issues:

Fix libretro/RetroArch#16730 (already fixed in #57)
Close #40

@viachaslavic viachaslavic force-pushed the ubuntu_core branch 7 times, most recently from d85c2c8 to dac80a4 Compare August 18, 2024 13:37
@viachaslavic viachaslavic marked this pull request as ready for review August 18, 2024 18:38
@hizzlekizzle
Copy link
Collaborator

is this one all ready to go?

@viachaslavic
Copy link
Contributor Author

viachaslavic commented Aug 25, 2024 •
edited
Loading

Yes, at this stage it is ready. But there is a issue with the implementation of the Wayland client in the code.

P.S. Following "best practices" I moved the snapcraft.yaml file to the snap folder, but the building, as before, must be runned from the root of the repository

@hizzlekizzle
Copy link
Collaborator

k, let's try it!

@hizzlekizzle hizzlekizzle merged commit 377aa4a into libretro:master Aug 25, 2024
@hizzlekizzle
Copy link
Collaborator

looks like adding the daemon field alongside the browser-support attribute triggered a manual review, which we failed:

(NEEDS REVIEW) 'daemon' should not be used with 'browser-support' security-snap-v2_daemon_with_browser-support (daemon)

Please adjust the snap without the use of daemon and browser-support

Can we just remove browser-support? I don't even remember why it's there, honestly.

@viachaslavic
Copy link
Contributor Author

According to the documentation, this interface use a browser API, not just an HTTP client. I also do not remember similar abilities in RA. I guess, we can try to exclude it for daemon, making a separate plugs list instead of the anchor.

@viachaslavic viachaslavic mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run from Snap on Ubuntu Core Feature request: Split Personality Snap
2 participants
@viachaslavic @hizzlekizzle