[Ready for RetroArch 1.19.2] sdl2: Remove PS4 Controller (v1).cfg -- Merge DualShock v1 and v2 in #1170
#1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restored `input_device = "PS4 Controller"`, see libretro/docs#984
davidhedlund
changed the title
PS4 Controller (v1).cfg
davidhedlund
changed the title
PS4 Controller (v1).cfgPS4 Controller (v1).cfg
input_device_display_name = "PlayStation 4 (PS4) Sony DualShock 4 v1 Controller"
davidhedlund
changed the title
PS4 Controller (v1).cfgPS4 Controller (v1).cfg
davidhedlund
changed the title
PS4 Controller (v1).cfgPS4 Controller (v1).cfg
davidhedlund
changed the title
PS4 Controller (v1).cfgPS4 Controller (v1).cfg with input_product_id_alt1
davidhedlund
changed the title
PS4 Controller (v1).cfg with input_product_id_alt1PS4 Controller (v1).cfg -- Merged DualShock v1 and v2 in #1170
davidhedlund
changed the title
PS4 Controller (v1).cfg -- Merged DualShock v1 and v2 in #1170PS4 Controller (v1).cfg -- Merged DualShock v1 and v2 in #1170
davidhedlund
changed the title
PS4 Controller (v1).cfg -- Merged DualShock v1 and v2 in #1170PS4 Controller (v1).cfg -- Merge DualShock v1 and v2 in #1170
RobLoach
requested changes
Sep 28, 2024
sdl2/PS4 Controller (v1).cfg
Outdated
Comment on lines
3
to
4
| input_vendor_id = "1356" | ||
| input_product_id = "1476" |
There was a problem hiding this comment.
If we merge both the PRs, we then are missing a config with this vendor/product ID pair. Would you mind merging the related PRs together so it's easier to review the diff? Thanks.
There was a problem hiding this comment.
I merged the v1 VID/PID to https://github.com/libretro/retroarch-joypad-autoconfig/pull/1170/files
input_vendor_id = "1356"
input_product_id = "1476"
PS4 Controller (v1).cfg -- Merge DualShock v1 and v2 in #1170PS4 Controller (v1).cfg -- Merge DualShock v1 and v2 in #1170
restore sdl2/PS4 Controller (v1).cfg
|
Merged: f5d9716 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input_vendor_id_alt1 = "1356"in [Ready for RetroArch 1.19.2] sdl2: CreatePS4 Controller.cfg#1170 is used to handle both v1 and v2.