Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready for RetroArch 1.19.2] udev: Update and rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo Switch Pro Controller #1186

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[Ready for RetroArch 1.19.2] udev: Update and rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo Switch Pro Controller #1186

wants to merge 14 commits into from

Conversation

davidhedlund
Copy link
Contributor

@davidhedlund davidhedlund commented Aug 26, 2024 •
edited
Loading

  • Generated with RetroArch Flathub's release version 1.19.0
  • Added alternative names: Autoconfig extension with alternative name/vid/pid RetroArch#16990
  • Streamlined the autoconfig file by removing comments and blank lines, sorting variables, and adding labels.
  • Created modified copies to make the controller identified by all Linux kernels with HID support for this controller.
  • Added input_screenshot_btn/input_screenshot_label for the unused screenshot button.

@davidhedlund davidhedlund changed the title Update Nintendo Co., Ltd. Pro Controller.cfg udev: Update Nintendo Co., Ltd. Pro Controller.cfg Aug 26, 2024
@davidhedlund davidhedlund mentioned this pull request Aug 26, 2024
Closed
@davidhedlund
udev: Create Pro Controller.cfg
e1a562d 
Copy of `Nintendo Co., Ltd. Pro Controller.cfg` but using Bluetooth name identifier.
@davidhedlund
Update Pro Controller.cfg
228d605 
input_device_display_name = "Nintendo Switch Pro Controller (Bluetooth)"
@davidhedlund
Update Nintendo Co., Ltd. Pro Controller.cfg
cd072b7 
input_device_display_name = "Nintendo Switch Pro Controller (USB)"
@davidhedlund
Create Nintendo Switch Pro Controller.cfg
6d5c10f 
copy of `Nintendo Co., Ltd. Pro Controller.cfg`
@davidhedlund davidhedlund changed the title udev: Update Nintendo Co., Ltd. Pro Controller.cfg udev: Update Nintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg and Pro Controller copies Aug 26, 2024
@davidhedlund davidhedlund changed the title udev: Update Nintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg and Pro Controller copies udev: Update Nintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies Aug 26, 2024
@davidhedlund davidhedlund mentioned this pull request Aug 26, 2024
Closed
@davidhedlund davidhedlund changed the title udev: Update Nintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies [READY] udev: Update Nintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies Aug 26, 2024
@davidhedlund davidhedlund changed the title [READY] udev: Update Nintendo Co., Ltd. Pro Controller.cfg and create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies [READY] udev: Update Nintendo Co., Ltd. Pro Controller.cfg. And create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies Aug 26, 2024
@davidhedlund davidhedlund changed the title [READY] udev: Update Nintendo Co., Ltd. Pro Controller.cfg. And create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies [WAIT] udev: Update Nintendo Co., Ltd. Pro Controller.cfg. And create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies Sep 2, 2024
@davidhedlund davidhedlund changed the title [WAIT] udev: Update Nintendo Co., Ltd. Pro Controller.cfg. And create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies [READY] udev: Update Nintendo Co., Ltd. Pro Controller.cfg. And create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies Sep 4, 2024
@davidhedlund
Delete udev/Nintendo Switch Pro Controller.cfg
b44d13b 
Avoid input_vendor_id/input_product_id conflict. Support multiple input_device and input_device_display_name variables - libretro/RetroArch#16907
@davidhedlund
Delete udev/Pro Controller.cfg
685239e 
Avoid input_vendor_id/input_product_id conflict. Support multiple input_device and input_device_display_name variables - libretro/RetroArch#16907
@davidhedlund
Update and rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo S…
8464355 
…witch Pro Controller.cfg

"Nintendo Switch Pro Controller" is used by both USB and Bluetooth for Linux 5.19, and 6.2.0
@davidhedlund davidhedlund changed the title [READY] udev: Update Nintendo Co., Ltd. Pro Controller.cfg. And create Nintendo Switch Pro Controller.cfg and Pro Controller.cfg copies [READY] udev: Update and rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo Switch Pro Controller Sep 4, 2024
@davidhedlund
Update Nintendo Switch Pro Controller.cfg
81e6f4d 
input_screenshot_btn = "4"
@davidhedlund
Update Nintendo Switch Pro Controller.cfg
bb39b96 
input_device = "Nintendo Switch Pro Controller"
input_device_alt1 = "Nintendo Co., Ltd. Pro Controller"
input_device_alt3 = "Pro Controller"
RobLoach
RobLoach requested changes Sep 28, 2024
View reviewed changes
Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change on alt2.

@davidhedlund davidhedlund changed the title [READY] udev: Update and rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo Switch Pro Controller [Ready for RetroArch 1.19.2] udev: Update and rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo Switch Pro Controller Oct 1, 2024
@davidhedlund
Update udev/Nintendo Switch Pro Controller.cfg
f8322bf 
That's an improvement, thanks!

Co-authored-by: Rob Loach <[email protected]>
davidhedlund
davidhedlund commented Oct 3, 2024
View reviewed changes
Copy link
Contributor Author

@davidhedlund davidhedlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobLoach RobLoach RobLoach requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhedlund @RobLoach