-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] sdl2: Update Nintendo Switch Pro Controller.cfg
#1156
base: master
Are you sure you want to change the base?
Conversation
… Ltd. Pro Controller.cfg "Nintendo Co., Ltd. Pro Controller" not "Nintendo Switch Pro Controller" with Linux 5.16 (confirmed)
sdl2/Nintendo Switch Pro Controller.cfg
renamed to Nintendo Co.,Ltd. Pro Controller.cfg renamed to sdl2/Nintendo Switch Pro Controller.cfg to Nintendo Co.,Ltd. Pro Controller.cfg
sdl2/Nintendo Switch Pro Controller.cfg
renamed to sdl2/Nintendo Co.,Ltd. Pro Controller.cfg
Thoroughly reconfigured. Utilized Ubuntu MATE 24.04 in live mode with Appimage 1.19.1, which accurately substituted _axis with _btn for input_l2 and input_r2, as this controller lacks pressure-sensitive triggers.
input_menu_toggle_btn = "11"
# Screenshot button (circle) is unbound in this autoconf, but has an ID of 4
sdl2/Nintendo Switch Pro Controller.cfg
renamed to sdl2/Nintendo Co.,Ltd. Pro Controller.cfg
sdl2/Nintendo Switch Pro Controller.cfg
renamed to sdl2/Nintendo Co.,Ltd. Pro Controller.cfg
. Remapped
sdl2/Nintendo Switch Pro Controller.cfg
renamed to sdl2/Nintendo Co.,Ltd. Pro Controller.cfg
. Remappedsdl2/Nintendo Switch Pro Controller.cfg
updated
sdl2/Nintendo Switch Pro Controller.cfg
updatedNintendo Switch Pro Controller.cfg
to Nintendo Co.,Ltd. Pro Controller.cfg
# input_r_x_plus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed. # input_r_y_minus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed.
removed: # input_r_x_plus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed. # input_r_y_minus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed. commented the wrong file
# This autoconfig file was generated using RetroArch 1.19.1 via the Flathub package. # Please refrain from updating it with an autoconfig created by the AppImage: SDL2 incorrectly creates udev autoconfig files - hizzlekizzle/RetroArch-AppImage#12
input_device = "Nintendo Co., Ltd. Pro Controller" generated from Linux 6.8.0
input_menu_toggle_btn = "5" # Screenshot button (circle) is unbound in this autoconf, but has an ID of 15
Nintendo Switch Pro Controller.cfg
to Nintendo Co.,Ltd. Pro Controller.cfg
Nintendo Switch Pro Controller.cfg
to Nintendo Co.,Ltd. Pro Controller.cfg
Unnecessary input_device in autoconfig files generated by the android, and sdl2 controller drivers - libretro/RetroArch#16920
Removed the final comments
…ontroller.cfg I mistakenly referred to the name for the "Nintendo Co., Ltd. Pro Controller" (udev). The correct SDL name is "Nintendo Switch Pro Controller." I verified this configuration using Remote RetroPad to ensure its accuracy.
Nintendo Switch Pro Controller.cfg
to Nintendo Co.,Ltd. Pro Controller.cfg
Nintendo Switch Pro Controller.cfg
input_screenshot_btn = "15"
input_vendor_id = "1406" | ||
input_product_id = "8201" | ||
|
||
input_a_btn = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're flipping A/B. RetroArch uses A for right face button, and B for the bottom face button. Is this change correct? You can see a visual of it over at:
https://www.lakka.tv/doc/Input-settings/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct (just generated a test autoconfig to verify it for you), it's generated by RetroArch 1.19.1.
I am confident that every single binding in all pull requests is 100% correct. The only manual additions I've made are for the analog L2/R2 buttons on PlayStation controllers, specifically for drivers that didn't generate them in RetroArch. I maintain a detailed spreadsheet that tracks all controllers, drivers, manual bindings, and bug reports.
All autoconfigurations I've uploaded since the release of RetroArch 1.19.1 have been generated from that version. I've tested every autoconfig 2-3 times.
I'm certain that all pull requests can be approved without the need to merge them and potentially review everything again. I would prefer not to spend additional time on this, as it has already taken a significant amount of effort to reach this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're flipping A/B. RetroArch uses A for right face button, and B for the bottom face button.
Since which RetroArch version (please give me a reference link if possible)?
- My Android autoconfigs have been generated with RetroArch 1.17.0 due a bug that prevents me from installing the current version (1.19.1). I submitted that bug here: [IMPORTANT]: Android APK version 1.19.0 and newer prompts for a password and fails to install on Android RetroArch#17014
input_screenshot_btn
/input_screenshot_label
for the unused screenshot button.input_screenshot_btn
/input_screenshot_label
for the unused screenshot button like I did for udev/linuxraw.