Separate checking the API from printing the statuses #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2016 19:21
…n run with a window closed (unlike lutro).
| end | ||
|
|
||
| lib.update = function (dt) | ||
| -- Now that the application has loaded, exit. | ||
| lib.window.close() | ||
| -- Note: closing the window does not exit love | ||
| if (lib.event ~= nil) and (lib.event.quit ~= nil) then | ||
| lib.event.quit() |
There was a problem hiding this comment.
Also added lib.event.quit() to Lutro recently too. Should we should be good to switch to that once builds are out.
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the issue #2 easier to deal with, I have separated the API checking from the status printing. A result table is firstly constructed and contains the type of element checked (module, function, type), its name, status (ok, missing, unknown), and the results for its children (the functions in a module for instance).
There are also differences from the previous version: