Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension checking and SG-1000 8KB RAM mapper #178

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jfroco
Copy link
Contributor

@jfroco jfroco commented Oct 13, 2024

  • Fix extension checking; files with two-character extensions like .sg are now working.
  • The SG-1000 8KB RAM expansion mapper is now functioning and runs most games.
  • Add SG-1000 games that use the expansion card.

Fix extension checking

Previously, four characters were used to determine the file extension (.xyz):

extension = workram + strlen(workram) - 4;

The issue with this approach is that extensions with only two characters, like .sg and .sc, were not handled correctly. I modified the code to retrieve just three characters. Extensions with three characters are compared without the dot, while those with two characters are compared including the dot.

SG-1000 8KB RAM expansion mapper

This mapper was not working and was not applied to any game in segadb.xml

It has been corrected and tested with the following games:

  • Rally-X crc32: AAAC12CF - working
  • Rally-X crc32: 306D5F78 - not working
  • Tank Battalion crc32: 5CBD1163 - not working
  • Yie Ar Kung-Fu II crc32: FC87463C - working
  • Bomberman Special crc32: 69FC1494 - working
  • Bomberman Special crc32: CE5648C3 - not working
  • The Legend of Kage crc32: 2E7166D5 - not working
  • Road Fighter crc32: 29E047CC - working
  • Road Fighter crc32: D2EDD329 - working
  • Knightmare crc32: 281D2888 - working
  • TwinBee crc32: C550B4F0 - working
  • King's Valley crc32: 223397A1 - working
  • Magical Kid Wiz crc32: FFC4EE3F - working
  • Star Soldier crc32: E0816BB7 - not working
  • Pippols crc32: DF7CBFA5 - working
  • The Castle (TW) crc32: 2E366CCF - working

- Fix extension checking; files with two-character extensions like .sg are now working.
- The SG-1000 8KB RAM expansion mapper is now functioning and runs most games.
- Add SG-1000 games that use the expansion card: Rally-X, Bomberman, Yie Ar Kung Fu II, Road Fighter, TwinBee, and Knightmare.
- Fix 8KB RAM mapper
- Follow MAME names (A and B)
- Add games: King's Valley, Magical Kid Wiz, Star Soldier, Pippols, and The Castle (TW).
@LibretroAdmin LibretroAdmin merged commit d898cd7 into libretro:master Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants