Netplay netpacket interface connection flow improvements #15986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow starting netplay host while a netpacket core is running without restart - Allow connecting to a host while a netpacket core is running without restart - Avoid clients getting stuck in connection loop if the host has the content paused while a client connects by automatically unpausing
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
- Allow starting netplay host while a netpacket core is running without restart - Allow connecting to a host while a netpacket core is running without restart - Avoid clients getting stuck in connection loop if the host has the content paused while a client connects by automatically unpausing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains some frontend usability improvements for the new libretro netpacket core interface introduced in #15413 and refined in #15887. This is purely improvements in the reference frontend RetroArch and there are no further changes to libretro.h this time.
Three things are addressed:
Because a core using the netpacket interface does not require the syncing up of Netplay participants' states, we don't need to restart the content when hosting a session or force a client to run the exact same content. Sometimes two players might actually want to run different contents and still connect together. A common example is a Pokemon game where there are multiple variants of a game that can all talk to each other over some communication peripheral like the Game Boy Advance Wireless Adapter.
All changes are only effective if the loaded core is using the new netpacket interface. So the existing regular netplay remains fully untouched.
Related Issues
Related Pull Requests
Reviewers