Remove menu_throttle_framerate option #15850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeOsborn
pushed a commit
to JoeOsborn/RetroArch
that referenced
this pull request
Nov 2, 2023
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's remove this option since it does not do anything, and it is not necessary. There is no reason to allow menu to run at unlimited speed, so instead of doing it regardless of the option by enforcing vsync on every toggle, let's just use the same frame time limiting method the VRR option is using.
The reasoning for this is because Vulkan will flash on menu toggle if built-in vsync is disabled and when in fullscreen. Using only the global vsync option instead of toggling it every time in menu also fits better when using 3rd party sync methods.
Also removed
RUNLOOP_STATE_MENU_ITERATEbecause it also does not serve any real purpose, and the condition for using it was very confusing and pointless. Correct me if I am wrong.Also made sure fast-forward and slow-motion are toggled off when entering menu, and some tab cleanups.
When using other swap intervals than 1, the removed menu vsync forcing might be warranted, since it also forces swap interval to 1, but it should only happen when vsync option is enabled. Please test with high and variable refresh rate hardware to see what happens and to make sure I'm not overlooking anything!