Shrink/Optimize Dockerfile #1430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested compiling the 4 target arches in the example in the Dockerfile from within the container after doing my modifications and it all succeeded so believe it's all good. |
|
I don't use Docker but sounds good to me! Would you resolve the conflict? |
|
The only comment I have is that to ensure it's still as easy as possible to comment lines out and just compile the platform you want. I think you got that with the new lines but I didn't check properly sorry. |
tomodachi
force-pushed
the
dockerfile_optimizing
branch
from
3ff23ee to
be5d40e
Compare
Changes Shrink the resulting image with 70mb by removing un-used dependencies and merging several runs to a single layer.
tomodachi
force-pushed
the
dockerfile_optimizing
branch
from
be5d40e to
c242ce5
Compare
|
@roderickvd Fixed the conflict (just a version bump for rust in rustup) @kingosticks It works exactly the same before, so no change in how you compile to specific platforms. |
|
Ok, great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Shrink the resulting image with 70mb by removing unused dependencies and merging several
runs to a single layer.