Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: audio key response timeout after 1.5s #1360

Merged

Conversation

kingosticks
Copy link
Contributor

I spotted then when trying to track down odd behaviour in gst-plugin-spotify where things seemingly hang. I'm not sure if this was the cause because it is really hard to reproduce, but it seems like it could be a problem....?

@kingosticks kingosticks force-pushed the audio-key-response-timeout branch from 58b5528 to f2137bd Compare October 3, 2024 20:55
core/src/audio_key.rs Outdated Show resolved Hide resolved
@roderickvd
Copy link
Member

Thanks. Don't remember running into it before, but it's a good catch. Let's fix it preventively.

Previously this could wait here indefinitely.
@kingosticks kingosticks force-pushed the audio-key-response-timeout branch from f2137bd to 6831433 Compare October 7, 2024 00:00
@roderickvd roderickvd merged commit 8b769e0 into librespot-org:dev Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants