Add network nodes list #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the first screen "Network Nodes" of this proposal.
Fixes #308 in part.
The nodes are shown alphabetically by hostname.
@spiccinini I've left out the three-dots actions menu you have proposed for the next iteration, maybe using popper.js. But I've include basic information (ipv4, ipv6, device, firmware) for each node in the list when you tap on it.
Future enhancements could be:
You can check it out here: https://germanferrero.github.io/lime-app/iframe.html?id=containers-networknodes--network-nodes-interactive&viewMode=story&args=#/networknodes