-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CI Actions #999
Bump CI Actions #999
Conversation
.github/workflows/main.yml
Outdated
@@ -39,7 +39,7 @@ jobs: | |||
- name: list any files left after uninstall | |||
run: (test -d _instdir && tree _instdir) || exit 0 | |||
# Capture all the meson logs, even if we failed | |||
- uses: actions/upload-artifact@v3 | |||
- uses: actions/upload-artifact@v4 | |||
if: ${{ always() }} # even if we fail | |||
with: | |||
name: meson test logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now need to have different names for different uploaded artifacts.
CI matrix only has meson arguments right now, we should add names there and reference them here.
Matrix could look like so:
matrix:
include:
- name: debug
meson_args: '-Druntime-dependency-checks=false'
- name: plain
meson_args: '-Druntime-dependency-checks=false -Dbuildtype=plain'
- name: release
meson_args: '-Druntime-dependency-checks=false -Dbuildtype=release'
and referencing new variable could be like this
name: meson test logs | |
name: 'meson test logs ${{ matrix.name }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think last commit updated actions/upload-artifact invocation without updating the matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I read your review way too fast.
Should be good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! :)
By the way, I'm not pushing you, but the back-end repo has a pretty much the same ticket ;) libratbag/libratbag#1649
14515db
to
ebb4b1b
Compare
Done! |
Fix #994
upload-artifact v4 artifacts are not backward compatible with v3 ones, so download-artifact v3 can't be used on them, but I didn't find any use of it in the organisation repositories, so I guess it's fine