Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI Actions #999

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Bump CI Actions #999

merged 1 commit into from
Oct 28, 2024

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented Oct 26, 2024

Fix #994

  • Bump CodeQL actions from v2 to v3
  • Bump checkout action from v3 to v4
  • Bump upload-artifact action from v3 to v4

upload-artifact v4 artifacts are not backward compatible with v3 ones, so download-artifact v3 can't be used on them, but I didn't find any use of it in the organisation repositories, so I guess it's fine

@@ -39,7 +39,7 @@ jobs:
- name: list any files left after uninstall
run: (test -d _instdir && tree _instdir) || exit 0
# Capture all the meson logs, even if we failed
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ always() }} # even if we fail
with:
name: meson test logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now need to have different names for different uploaded artifacts.
CI matrix only has meson arguments right now, we should add names there and reference them here.
Matrix could look like so:

      matrix:
        include:
          - name: debug
            meson_args: '-Druntime-dependency-checks=false'
          - name: plain
            meson_args: '-Druntime-dependency-checks=false -Dbuildtype=plain'
          - name: release
            meson_args: '-Druntime-dependency-checks=false -Dbuildtype=release'

and referencing new variable could be like this

Suggested change
name: meson test logs
name: 'meson test logs ${{ matrix.name }}'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think last commit updated actions/upload-artifact invocation without updating the matrix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I read your review way too fast.

Should be good now.

Copy link
Member

@staticssleever668 staticssleever668 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! :)
By the way, I'm not pushing you, but the back-end repo has a pretty much the same ticket ;) libratbag/libratbag#1649

@staticssleever668 staticssleever668 merged commit ebb4b1b into libratbag:master Oct 28, 2024
5 checks passed
@AFCMS
Copy link
Contributor Author

AFCMS commented Oct 28, 2024

Looks good, thank you! :) By the way, I'm not pushing you, but the back-end repo has a pretty much the same ticket ;) libratbag/libratbag#1649

Done!

libratbag/libratbag#1658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: update runners
2 participants