Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank app icon issues with KDE application launcher #894

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix blank app icon issues with KDE application launcher #894

merged 1 commit into from
Sep 19, 2023

Conversation

ahmetsait
Copy link
Contributor

Removes all unused mask and clip paths, crops the embedded image, optimizes file size and fixes render issues seen in KDE apps (Gwenview, Application Launcher, Application Dashboard etc.).

@staticssleever668
Copy link
Member

Just curious, what tools have you used to make this change?

@staticssleever668
Copy link
Member

Image still shows up in Rofi and Piper's about page.
If you open up the new image in Inkscape, there are no groups that contain unrelated paths together anymore, everything is in the top level.
Curious how the shadow uses an embedded PNG instead of also being made in SVG. 🤔
LGTM, thank you!

@ahmetsait
Copy link
Contributor Author

Just curious, what tools have you used to make this change?

Inkscape & Kate as text editor for fine grained edits.

Image still shows up in Rofi and Piper's about page. If you open up the new image in Inkscape, there are no groups that contain unrelated paths together anymore, everything is in the top level. Curious how the shadow uses an embedded PNG instead of also being made in SVG. 🤔 LGTM, thank you!

This can be done better with an inner drop shadow filter or a mesh gradient but those are not well supported in anything other than browsers so I left that highlight effect as an image.

For reference this is how it looked in Gwenview before the changes:

image

@ahmetsait
Copy link
Contributor Author

@staticssleever668 is this going to sit unmerged?

@staticssleever668 staticssleever668 merged commit dcf6db1 into libratbag:master Sep 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants