Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Structures): GuildIntegration missing optional #39

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

fix(Structures): GuildIntegration missing optional #39

wants to merge 2 commits into from
+10 −10

Conversation

SiroTM
Copy link
Collaborator

@SiroTM SiroTM commented Jun 9, 2021

This PR makes the following properties optional: enable_emoticons, expire_behavior, revoked, role_id, subscriber_count, syncing and user.
This also renames IntegrationExpireBehaviour to IntegrationExpireBehavior .

bsian03
bsian03 requested changes Jun 9, 2021
View reviewed changes
Copy link
Member

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keeping the types as they are but default export a union of GuildIntegration and BotIntegration in this case

@Khaaz
Copy link
Collaborator

Khaaz commented Jun 12, 2021

lol uk vs us naming.
I agree with accepting both names potentially.
Otherwise we just need to choose one and be consistent about it

@Khaaz Khaaz changed the title refactor(Structures): GuildIntegration fix(Structures): GuildIntegration missing optional Jun 12, 2021
@Khaaz Khaaz added repo: structures semver: patch t: documentation Improvements or additions to documentation t: fix Something isn't working labels Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsian03 bsian03 bsian03 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
repo: structures semver: patch t: documentation Improvements or additions to documentation t: fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiroTM @Khaaz @bsian03