Change return types to prima_rc_t #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help users figure out how and where to look up any error codes they might receive while trying to use PRIMA.
I agree. Should we call it |
|
|
nbelakovski
commented
Apr 13, 2024
…/checks?check_run_id=24006379701, which complains that "a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] unsigned int get_random_seed()"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help users figure out how and where to look up any error codes they might receive while trying to use PRIMA.
There's a small problem which isn't created by this PR but is "surfaced" by it - many of the C functions we use return 0 on success, which is fairly standard in the C world. However the
prima_rc_tvalue for 0 isPRIMA_SMALL_TR_RADIUS, which is not very intuitive.I see that infos.f90 defines both
SMALL_TR_RADIUSandINFO_DFTas 0, should we definePRIMA_DFTas 0 as well in prima.h?