Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wordlist): remove word hitler #479

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

zhijie-yang
Copy link

@zhijie-yang zhijie-yang commented Sep 5, 2024

Description

For the sake of anti-fascism, the word [Hh]itler should be removed from the word list. Or if removing it from the word list is unacceptable, its frequency should be no higher than the word [Hh]i. Currently its frequency tops the words starting with Hi*. Otherwise when users are typing "Hi", the first suggested English word candidate will be Hitler instead of Hi, nor any other words that make more sense.

Issue statement

The screenshot shows the English word suggestion candidates when "Hi" is typed on a fresh installation of this IME without any wording preference set.
Screenshot from 2024-09-06 00-14-19

@zhijie-yang zhijie-yang force-pushed the remove-hitler-from-wordlist branch from a091aaf to 37982d9 Compare September 5, 2024 23:51
@zhijie-yang zhijie-yang force-pushed the remove-hitler-from-wordlist branch from 37982d9 to 939521c Compare September 5, 2024 23:53
@epico epico merged commit 617b16c into libpinyin:main Sep 6, 2024
1 check passed
@epico
Copy link
Member

epico commented Sep 6, 2024

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants