Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Clippy Beta #5700

Merged
merged 5 commits into from
Nov 28, 2024
Merged

fix(ci): Clippy Beta #5700

merged 5 commits into from
Nov 28, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 28, 2024 •
edited by guillaumemichel
Loading

Description

Fixes CI failure in Clippy (Beta)

https://github.com/libp2p/rust-libp2p/actions/runs/12055058396/job/33614543029

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@hanabi1224 hanabi1224 marked this pull request as ready for review November 28, 2024 01:53
@guillaumemichel
Copy link
Contributor

Thanks @hanabi1224! Could you also update the CHANGELOGs of crates where required?

@hanabi1224
Copy link
Contributor Author

Thanks @hanabi1224! Could you also update the CHANGELOGs of crates where required?

@guillaumemichel Done.

guillaumemichel
guillaumemichel approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanabi1224!

transports/noise/CHANGELOG.md Outdated Show resolved Hide resolved
transports/webtransport-websys/CHANGELOG.md Outdated Show resolved Hide resolved
@guillaumemichel guillaumemichel added send-it-batch send PR to the batch queue to run interop tests and removed send-it-batch send PR to the batch queue to run interop tests labels Nov 28, 2024
@guillaumemichel guillaumemichel added the send-it-batch send PR to the batch queue to run interop tests label Nov 28, 2024
@mergify mergify bot merged commit 930118e into libp2p:master Nov 28, 2024
71 of 72 checks passed
@hanabi1224 hanabi1224 deleted the fix-ci-clippy-beta branch November 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumemichel guillaumemichel guillaumemichel approved these changes

Assignees
No one assigned
Labels
send-it-batch send PR to the batch queue to run interop tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanabi1224 @guillaumemichel