Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update sysinfo to 0.32 #5691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

getong
Copy link

@getong getong commented Nov 26, 2024

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@getong getong changed the title update sysinfo to 0.32 chore(deps): update sysinfo to 0.32 Nov 26, 2024
@getong
Copy link
Author

getong commented Nov 26, 2024

macos compile error msg:

error[E0599]: no method named `len` found for type `i8` in the current scope
    --> /Users/a/.cargo/registry/src/rsproxy.cn-0dccff568467c15b/sysinfo-0.30.13/src/unix/apple/macos/process.rs:436:53
     |
436  |         Some(node.vip_path.len() * node.vip_path[0].len()),
     |                                                     ^^^
     |
help: there is a method `le` with a similar name, but with different arguments
    --> /Users/a/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/cmp.rs:1196:5
     |
1196 |     fn le(&self, other: &Rhs) -> bool {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks for this! Can you not run cargo update? There's some patch crate update that is breaking the CI, both the webrtc tests and clippy. We need to figure out which one it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants